Add detection of %posttrans and %pretrans scriptlet from rpm header

In specs files, user may use %posttrans and %pretrans scriptlet like this: Requires(pretrans): test_pkg Requires(posttrans): test_pkg This commit add detection to the above special scriptlet Signed-off-by: Shuo Wang <[email protected]>
rpm-software-management · Mar 18, 2024 · 3796d57 · 3796d57
1 parent a0d5953
commit 3796d57
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 2 deletions.
diff --git a/src/parsehdr.c b/src/parsehdr.c
@@ -425,6 +425,8 @@ cr_package_from_header(Header hdr,
                     // Calculate pre value
                     if (num_flags & (RPMSENSE_PREREQ |
                                      RPMSENSE_SCRIPT_PRE |
+                                     RPMSENSE_POSTTRANS |
+                                     RPMSENSE_PRETRANS |
                                      RPMSENSE_SCRIPT_POST))
                     {
                         pre = 1;

diff --git a/tests/python/tests/test_package.py b/tests/python/tests/test_package.py
@@ -85,7 +85,9 @@ def test_package_archer(self):
             ('fooc', 'EQ', '0', '3', None, False),
             ('food', 'LT', '0', '4', None, False),
             ('fooe', 'GT', '0', '5', None, False),
-            ('foof', 'EQ', '0', '6', None, True)
+            ('foof', 'EQ', '0', '6', None, True),
+            ('foog', 'EQ', '0', '7', None, True),
+            ('fooh', 'EQ', '0', '8', None, True)
             ])
         self.assertEqual(pkg.provides, [
             ('bara', 'LE', '0', '22', None, False),

diff --git a/tests/python/tests/test_sqlite.py b/tests/python/tests/test_sqlite.py
@@ -195,7 +195,9 @@ def test_sqlite_primary(self):
              (u'fooc', u'EQ', u'0', u'3', None, 1, u'FALSE'),
              (u'food', u'LT', u'0', u'4', None, 1, u'FALSE'),
              (u'fooe', u'GT', u'0', u'5', None, 1, u'FALSE'),
-             (u'foof', u'EQ', u'0', u'6', None, 1, u'TRUE')])
+             (u'foof', u'EQ', u'0', u'6', None, 1, u'TRUE'),
+             (u'foog', u'EQ', u'0', u'7', None, 1, u'TRUE'),
+             (u'fooh', u'EQ', u'0', u'8', None, 1, u'TRUE')])
 
         # Check files table
         self.assertEqual(con.execute("select * from files").fetchall(),

diff --git a/tests/python/tests/test_xml_file.py b/tests/python/tests/test_xml_file.py
@@ -227,6 +227,8 @@ def test_xmlfile_add_pkg(self):
       <rpm:entry name="food" flags="LT" epoch="0" ver="4"/>
       <rpm:entry name="fooe" flags="GT" epoch="0" ver="5"/>
       <rpm:entry name="foof" flags="EQ" epoch="0" ver="6" pre="1"/>
+      <rpm:entry name="foog" flags="EQ" epoch="0" ver="7" pre="1"/>
+      <rpm:entry name="fooh" flags="EQ" epoch="0" ver="8" pre="1"/>
     </rpm:requires>
     <rpm:conflicts>
       <rpm:entry name="bba" flags="LE" epoch="0" ver="2222"/>

diff --git a/tests/testdata/packages/Archer-3.4.5-6.x86_64.rpm b/tests/testdata/packages/Archer-3.4.5-6.x86_64.rpm
diff --git a/tests/testdata/specs/fake-Archer.spec b/tests/testdata/specs/fake-Archer.spec
@@ -16,6 +16,8 @@ Requires: fooc = 3
 Requires: food < 4
 Requires: fooe > 5
 Requires(pre): foof = 6
+Requires(pretrans): foog = 7
+Requires(posttrans): fooh = 8
 
 Provides: bara <= 22
 Provides: barb >= 11.22.33-44