[BugFix] Image has already been loaded #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the image has already been loaded and it can't trigger the `onload` event. So we should check if the image has been loaded before binding the event, and if it has been loaded, we can call `setLoaded` directly. Otherwise, bind the `onload` event.
|
For https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/complete For https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/naturalHeight |
|
@zjhch123 Thank you for this contribution! I will look at it when I get time in the next day or two (it is a holiday here). |
1 similar comment
|
@zjhch123 Thank you for this contribution! I will look at it when I get time in the next day or two (it is a holiday here). |
|
This is still on my TO DO list. Thanks for the latest commit |
|
I'm extremely sorry for the delay here. I'm testing this now... |
rpearce
approved these changes
Feb 25, 2023
|
This has been released in |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the image has already been loaded and it can't trigger the
onloadevent. So we should check if the image has been loaded before binding the event, and if it has been loaded, we can callsetLoadeddirectly. Otherwise, bind theonloadevent.Testing
Take the screenshot as an example:
Because
epid4.pnghas already been loaded, so theonloadevent doesn't be triggered as expected and the DOM showsdata-rmiz-content="not-found".After my change, it works!
Please let me know if any questions.
Thanks.