fix(client): Include request in initial subscribe to gRPC endpoint to fix LB connection delay #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
fanatid
pushed a commit
that referenced
this pull request
Dec 4, 2023
…LB connection delay (#252) * send request with subscribe * remove unused import
This was referenced Dec 5, 2023
fanatid
pushed a commit
that referenced
this pull request
Dec 7, 2023
…fix LB connection delay (backport of #252) (#255) * send request with subscribe * remove unused import (cherry picked from commit 4239bb7) Co-authored-by: Liam Vovk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some load balancers (eg. Cloudflare) expect a message to come through before passing a gRPC connection through to origin. Because the current subscribe method connects, and then sends a message, it causes a delay when connecting. This pr adds
subscribe_with_requestwhich pushes a request into the channel before sending the subscribe request. This resolves the LB issue