Setup miniconda action #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also:
* install setuptools-conda from labscript-suite
* build conda packages in ${{ runner.temp }}\cb on Windows, which is a
short filepath. This helps avoid very long filepaths causing failure
during the build.
| pip install --upgrade setuptools_scm && ^ | ||
| setuptools-conda build %CONDA_BUILD_ARGS% . | ||
| conda install -c labscript-suite setuptools-conda && ^ | ||
| setuptools-conda build %CONDA_BUILD_ARGS% --croot ${{ runner.temp }}\cb . |
There was a problem hiding this comment.
This line is the result of many hours of misery.
Some builds of projects with C extensions fail with errors like:
The input line is too long.
The syntax of the command is incorrect.
This is because of long filepaths. The conda build would be done in a directory like:
D:\a\labscript-c-extensions\labscript-c-extensions\conda_build\conda-bld\
Using ${{ runner.temp }}\cb instead results in the conda build being done in the directory:
D:\a\_temp\cb\
saving many characters in the filepath and causing the builds to not fail with the "input line too long" error
|
Merging as the build is broken as it is, and fixing it when I'm changing stuff anyway is pointless. This change is tested in other labscript repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace our home-grown miniconda setup with the existing
setup-minicondaGitHub action.The latest version has a bug, fixed upstream but with the fix not merged yet (it's been a long time so probably won't be merged soon):
conda-incubator/setup-miniconda#189
That prevents it working on 32 bit Windows. That's OK, we can hard-code a working version of the action until the fix is in a release of the action.