Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxing dependencies and moving to Hatch and Pixi #130

Merged
merged 19 commits into from
Jul 25, 2024
Merged

Relaxing dependencies and moving to Hatch and Pixi #130

merged 19 commits into from
Jul 25, 2024

Conversation

JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented Jul 16, 2024

@ilan-theodoro I broke your API when updating pydantic could you take a look at it?
I could not figure it out, it seems a fastapi problem.

@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 17, 2024

I'm waiting for higra to support numpy 2.0.0, higra/Higra#277

@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 23, 2024

@ilan-theodoro I changed the CLI a bit. The config could be optional; we generate a template, and they modify it.

@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 23, 2024

I also included additional changes to close other bugs, hehe, sorry.

@JoOkuma JoOkuma requested a review from ilan-theodoro July 23, 2024 17:52
@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 23, 2024

@ilan-theodoro could you review this PR?

@ilan-theodoro
Copy link
Member

lgtm!

I just think that we need to submit an issue remembering us to update our pydantic models to 2.*, what do you think?

@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 24, 2024

Probably the last one, @ilan-theodoro. Do you think the Windows error is related to the "server" test?
I assume it isn't because of the "terminate/join".

@ilan-theodoro
Copy link
Member

@JoOkuma it was. The problem is that it got killed trying to remove a sqlite db that was open somewhere. I fixed that with an empty try-catch on the removal procedure

@JoOkuma
Copy link
Member Author

JoOkuma commented Jul 25, 2024

@ilan-theodoro, thanks; we can fix it later.

@JoOkuma JoOkuma merged commit 2d35e3e into main Jul 25, 2024
5 of 7 checks passed
@JoOkuma JoOkuma deleted the hatch branch July 25, 2024 20:29
This was referenced Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants