Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Select Cells Tip #70

Merged
merged 3 commits into from
May 10, 2024
Merged

Show Select Cells Tip #70

merged 3 commits into from
May 10, 2024

Conversation

ehoops-cz
Copy link
Collaborator

Resolves #65

Add a callout to tell the user how to select cells. This PR shows the callout whenever no tracks are on the canvas.
This is mostly the same as the original PR here.

It's a little laggy because it waits until the tracks get to the canvas. I think this is ok.
Apr-26-2024 12-45-39

@ehoops-cz ehoops-cz requested a review from aganders3 April 26, 2024 19:46
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
points-web-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 4:48pm

@ehoops-cz ehoops-cz requested a review from andy-sweet April 26, 2024 19:46
Copy link
Collaborator

@aganders3 aganders3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thank you!

src/components/App.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@andy-sweet andy-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. This looks good enough to me!

Would be good to clarify the in-line comments, but not required to merge.

@ehoops-cz ehoops-cz merged commit 10e4752 into main May 10, 2024
3 checks passed
@ehoops-cz ehoops-cz deleted the select-cells-tip-2 branch May 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show tip for how to select cells
3 participants