Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass initial camera properties through PointCanvas constructor #62

Closed
andy-sweet opened this issue Apr 4, 2024 · 0 comments · Fixed by #95
Closed

Pass initial camera properties through PointCanvas constructor #62

andy-sweet opened this issue Apr 4, 2024 · 0 comments · Fixed by #95

Comments

@andy-sweet
Copy link
Collaborator

andy-sweet commented Apr 4, 2024

We currently call setCameraProperties to pass through the initial values of those when mounting the Scene component, but it would be simpler to just pass them through the constructor to avoid the extra call.

aganders3 added a commit that referenced this issue Apr 5, 2024
* Update names

* Icon changes, add DataControls for info, copy URL, and set data URL

* Add Zebrahub logo

* Remove commented code. Tweak appearance.

* Match toolbar sizes

* Fix SDS deprecation warning

* Partially functioning popover for Zarr URL input

* Add snackbar when copying URL

* Minor padding tweaks

* Use frames instead of percent for track highlight length

* Remove arbitrary camera position and target in PointCanvas constructor (see #62)

* Update data URL input to use cancel/apply buttons instead of loading immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant