Intercept unhandled rejections that are potentially caused by errors from jsdom #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizzao
force-pushed
the
rejection-handling
branch
from
238560e to
041358c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej @jakobrosenberg,
This is a potential fix for the issues described in roxiness/routify-starter#97.
Basically, jsdom errors cause Node to exit (jsdom/jsdom#2346) so this stops it from doing that. It's a little dangerous, but maybe fine if all the process is doing is handling SSR requests.
Happy to entertain any other ideas as well.