-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto add suggested field names for csv import vGHC for OSD #548
Auto add suggested field names for csv import vGHC for OSD #548
Conversation
…d-536-add-suggested-field-names-for-csv-import
…o intentionally make the pair object with tableColumnPairs
Screen.Recording.2021-10-01.at.6.21.50.PM.mov |
Hi @DariaNico, thanks for your contribution! I noticed that this solution doesn’t let you continue to step 2, and doesn’t end up writing the column pairs to the config.
Suggesting the column match is better suited right after the user states they want to import a CSV column, so I moved the logic there (lines 108–119) You can review the fix in this commit: 796f4f1 |
PR to address issue #536 for Open Source Day hackathon/vGHC
config.pairs
is not populated when settingcolumnKey
, thus_find
function always returns undefined, meaningcolumnKey
is always set tonull
. This fix intentionally makes a pair array with tableColumns, thus allowing_find' to work, thus allowing
columnKey` to be set.