Implement auto import for array subtables #1302
Conversation
|
@rishipurwar1 is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@harinij @shamsmosowi please review my PR. |
src/components/Table/EmptyTable.tsx
Outdated
| if (tableSettings.isCollection !== false && hasData) { | ||
| if ( | ||
| (tableSettings.isCollection !== false || | ||
| tableSettings.subTableKey?.length) && |
There was a problem hiding this comment.
@rishipurwar1 how is tableSettings.subTableKey?.length used here, could we just remove tableSettings.isCollection !== false part of the condition?
There was a problem hiding this comment.
how is tableSettings.subTableKey?.length used here
I used it to check whether an array subTable key exists or not, if it exists and hasData flag is true, then show the "import existing data" template.
could we just remove
tableSettings.isCollection !== falsepart of the condition?
Yes, we can do that. That way, we only need to check for the hasData flag, if it's true then show the "import existing data" template.
There was a problem hiding this comment.
Updated the if condition.
There was a problem hiding this comment.
@iamanishroy what do you think? is there any other conditions we should watch out for?
This PR fixes issue #1284. Now, Rowy can detect and suggest the schema for the array suitable.
Screen.Recording.2023-06-17.at.9.57.33.AM.mov