Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ids are broken, often they are same and look this way: 000000000000000000undefined #567

Closed
n-sviridenko opened this issue Oct 20, 2021 · 2 comments
Closed

Document ids are broken, often they are same and look this way: 000000000000000000undefined #567

n-sviridenko opened this issue Oct 20, 2021 · 2 comments
Assignees
@notsidney
Labels
bug Something isn't working
Milestone
v2.2

Comments

@n-sviridenko
Copy link
Contributor

Newly generated document ids are often broken:

Снимок экрана 2021-10-20 в 17 17 46

I'm having around 300 records in my database.

Seems like generateSmallerId returns undefined sometimes. Didn't dig much into this and just replaced it with db.collection(path).doc().id, but the issue is that it's used to retain the documents order. So we need to find a proper solution.
@n-sviridenko
Copy link
Contributor Author

Furthermore, generateSmallerId doesn't really solve the problem and often documents are randomly inserted at any position.

@n-sviridenko
Copy link
Contributor Author

https://www.loom.com/share/7c9b65942b9844aebfa906b9688c8fa3

@notsidney notsidney added the bug Something isn't working label Oct 21, 2021
@notsidney notsidney added this to the v2.2 milestone Oct 21, 2021
@notsidney notsidney self-assigned this Oct 21, 2021
notsidney added a commit that referenced this issue Oct 28, 2021
@notsidney
fix generateSmallerId algorithm (#567)
dceabe3
notsidney added a commit that referenced this issue Oct 28, 2021
@notsidney
Merge branch 'develop' into feat/webhooks
47535ed 
* develop: (21 commits)
  generateBiggerId: remove console.log
  fix generateSmallerId algorithm (#567)
  fix merge
  fix inline cell of connect-service
  Fixes issue where the title field name is shown rather than the value
  Update reload screen copy (#530)
  Derivatives: don't list current field in listener field options
  potentially fix side drawer randomly scrolling
  JSON field: improve tree editor dark mode
  JSON: fix array support
  CodeEditor: use text field background color
  added a temp skip button for rules setting step
  JSON editor: add code editor mode (#509)
  CodeEditor: use TextField box-shadows & fix RichTextEditor box-shadows
  CodeEditor: fix onChange not being passed as prop
  consolidate CodeEditor to components/CodeEditor, allow resize, use github themes
  add CircularProgressOptical
  Import CSV: prevent import to ID field
  Import CSV: fix crash
  User Settings: move darker dark mode to theme
  ...
notsidney added a commit that referenced this issue Nov 25, 2021
@notsidney
fix decrementId (#567), CSV new row ID bug (#583), add row with custo…
5cff617 
…m ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notsidney notsidney

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
3 participants
@n-sviridenko @shamsmosowi @notsidney