[pgadmin4] fix bug where secret isnt created when using .serverDefinitions.resourceType #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is an addition to my previous one #249.
It fixes a bug, where the Secret manifest for Server Definitions isn't created, when
.existingSecretis definied - which is usally the case when credentials are defined in a Secret.The combination of
.serverDefinitions.resourceType: Secretand.serverDefinitions.servers: {firstServer: ...}now creates the corresponding secret.Special notes for your reviewer:
Main issue is the
(not .Values.existingSecret)hereChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[pgadmin4])