[pgadmin4] feat: add possibility to use template-strings inside value…

…s.yaml (#232) * feat: add possibility to use template-strings inside values.yaml for "extraConfigmapMounts.[].configMap" and "extraSecretMounts.[].secret" * feat: bump Chart version to 1.19.0 * feat: update README.md --------- Signed-off-by: pmoscode <[email protected]>
rowanruseler · Dec 18, 2023 · d619d95 · d619d95
1 parent 9b970b2
commit d619d95
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/charts/pgadmin4/Chart.yaml b/charts/pgadmin4/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: pgAdmin4 is a web based administration tool for PostgreSQL database
 name: pgadmin4
-version: 1.18.5
+version: 1.19.0
 appVersion: "7.8"
 keywords:
   - pgadmin

diff --git a/charts/pgadmin4/README.md b/charts/pgadmin4/README.md
@@ -121,6 +121,10 @@ The command removes nearly all the Kubernetes components associated with the cha
 | `test.resources` | CPU/memory resource requests/limits for test | `{}` |
 | `test.securityContext` | Custom [security context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) for test Pod | `` |
 
+> The values for "extraConfigmapMounts.[].configMap" and "extraSecretMounts.[].secret" can be either a simple string
+or a template string.
+Then it will be resolved for you.
+
 Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example:
 
 ```console

diff --git a/charts/pgadmin4/templates/deployment.yaml b/charts/pgadmin4/templates/deployment.yaml
@@ -201,13 +201,13 @@ spec:
       {{- range .Values.extraConfigmapMounts }}
         - name: {{ .name }}
           configMap:
-            name: {{ .configMap }}
+            name: {{ tpl (.configMap) $ }}
             defaultMode: {{ .defaultMode | default 256 }}
       {{- end }}
       {{- range .Values.extraSecretMounts }}
         - name: {{ .name }}
           secret:
-            secretName: {{ .secret }}
+            secretName: {{ tpl (.secret) $ }}
             defaultMode: {{ .defaultMode | default 256 }}
       {{- end }}
       {{- if .Values.extraVolumes }}