Skip to content

Commit

Permalink
[pgadmin4] Removed image.tag from app.kubernetes.io/version (#268)
Browse files Browse the repository at this point in the history
Pinning the `image.tag` to a specific digest allows full control over
what image is actually deployed. But at the moment this breaks the chart
because a label must be no more than 63 characters.

This commit resolves:
* /issues/267
  • Loading branch information
rowanruseler authored Dec 4, 2024
1 parent e348225 commit 69d0ae0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/pgadmin4/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: pgAdmin4 is a web based administration tool for PostgreSQL database
name: pgadmin4
version: 1.33.2
version: 1.33.3
appVersion: "8.13"
keywords:
- pgadmin
Expand Down
2 changes: 1 addition & 1 deletion charts/pgadmin4/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Common labels
{{- define "pgadmin.labels" -}}
app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/name: {{ include "pgadmin.name" . }}
app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
helm.sh/chart: {{ include "pgadmin.chart" . }}
{{- with .Values.commonLabels }}
{{ toYaml . }}
Expand Down

0 comments on commit 69d0ae0

Please sign in to comment.