Recent Django / Python improvements #51
Conversation
`smart_text` is deprecated, and will be removed in the next Django major release. This change squelches warnings about that and makes sure we stay future-proof.
Drop Pythons that have reached upstream EOL. Also run tests with more recent pythons. Hint: I'm using this in production in some large-scale apps with Django 3.0 and Python 3.8. It's been working fine.
Django 1.11 has reached its EOL, and won't work with recent (and not-so-recent) versions of Python. Drop support for this; projects still using older Pythons can just keep using older versions of this library.
The PNG one is too blurry on hidpi screens.
|
@melinath @roverdotcom Could you merge these changes? |
|
Sorry, I'm no longer at Rover. @philipkimmey - heads up if you want to take a look at this! |
|
Ah, thanks for the heads up. If there's no longer anyone dedicated to maintaining the project, what do you think of moving this to Jazzband to be community-maintained? |
|
Totally agree for JazzBand. But we need to hear someone from the @roverdotcom. |
| from __future__ import print_function | ||
| from __future__ import unicode_literals | ||
|
|
||
|
|
||
| try: | ||
| import importlib | ||
| except ImportError: |
There was a problem hiding this comment.
In python 3 just import importlib .
There is no from django.utils import importlib in django 2.2
|
Hey @WhyNotHugo + @Mogost ! Sorry for the radio silence here - I wrote this many years ago and we don't really use it internally anymore so I think moving it to JazzBand is a great idea. If you add me as a member there I'm happy to transfer it over and whatnot! |
JazzBand membership is open. You can join at any time. More information is available on the JazzBand site. If the JazzBand does not accept us, I see @WhyNotHugo as a good candidate to pick up this project. As far as I can see, this fork belongs to you. |
|
Whoops - sorry about that, that makes sense. I'm signing up over there now. |
|
Many thanks for addressing that! |
|
Any hope this great PR will be merged and released ? 🙏 |
|
@WhyNotHugo - did you take control of this lib? |
|
@heidi-hayden nope. I was hoping it'd be moved into jazzband, but still waiting on that. |
|
@philipkimmey is there a reason why this project hasn't moved to JazzBand yet? It seems a shame to let this sit idle when there appears to be people willing to maintain it. Not sure what I can contribute at this stage, but if I can help out with getting things moving let me know. |
smart_text, which is a warning on Django 3.0, and will fail with the next major release(note:. Django 1.11 won't work on recent (and not-so-recent) versions of Python, so drop that too. It's already past its EOL too.smart_stris already present in Django 1.11, so this doesn't drop support for that)Note: Projects that can't update for some reason can still use older versions of this library anyway, anyone using such old Pythons/Django already has pinned dependencies anyway.