Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code display component #29

Merged
merged 5 commits into from
Oct 3, 2018

Conversation

cabarnes
Copy link
Member

@cabarnes cabarnes commented Oct 2, 2018

Next step of #20
Create a code viewer component. Opens a modal to display the blockly code in JavaScript:
image

Copy link
Contributor

@hbradio hbradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! +1 on the monokai theme.

Nitpick:
Clicking outside the modal works, but an explicit button would also be good.
I'm not seeing a semantic-ui flag to add a "close modal" x. Could we manually add a "close" button?

@cabarnes
Copy link
Member Author

cabarnes commented Oct 2, 2018

Looks like that should be simple: https://react.semantic-ui.com/modules/modal/#variations-close-icon

@cabarnes
Copy link
Member Author

cabarnes commented Oct 2, 2018

@aninternetof I've added the close icon. I also thought it would be a good idea to be able to set the text on the button from the parent.

Copy link
Contributor

@hbradio hbradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the changes!

@cabarnes cabarnes merged commit 00ecf6a into rovercode:development Oct 3, 2018
@cabarnes cabarnes deleted the code-display-component branch October 3, 2018 01:22
@hbradio hbradio added this to the Beta milestone Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants