-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code display component #29
Code display component #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! +1 on the monokai theme.
Nitpick:
Clicking outside the modal works, but an explicit button would also be good.
I'm not seeing a semantic-ui flag to add a "close modal" x
. Could we manually add a "close" button?
Looks like that should be simple: https://react.semantic-ui.com/modules/modal/#variations-close-icon |
@aninternetof I've added the close icon. I also thought it would be a good idea to be able to set the text on the button from the parent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the changes!
Next step of #20
Create a code viewer component. Opens a modal to display the blockly code in JavaScript: