Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consider onConfigurationChanged. #787

Closed
wants to merge 1 commit into from

Conversation

Rake-Kharton
Copy link

Purpose

For handling orientation changes.
Before this fix, each of tabs has too small size when the orientaion is changed.

Reproduction steps

  1. Handle the configuration change yourself
<activity android:name=".ThreeTabsActivity"
            android:configChanges="orientation|screenSize"/>
  1. Start sample app with portrait screen orientation and change to landscape

Images

Portrait Landscape
Before before_portrait before_landscape
After Same to portrait orientation's after_landscape

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 63.101% when pulling 65c1ec0 on Rake-Kharton:development into e09852b on roughike:development.

@Rake-Kharton Rake-Kharton changed the title Consider onConfigurationChanged. WIP: Consider onConfigurationChanged. May 31, 2017
@Rake-Kharton
Copy link
Author

Rake-Kharton commented May 31, 2017

This PR commits to development branch now, so I change base branch to master.

@Rake-Kharton
Copy link
Author

I fixed base branch and send new PR. #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants