Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix output examples for ToJSON #117

Merged
merged 1 commit into from
Feb 13, 2023
Merged

docs: fix output examples for ToJSON #117

merged 1 commit into from
Feb 13, 2023

Conversation

sarnikowski
Copy link
Contributor

Proposed changes

The godoc of ToJSON is incorrect. Internally it calls ToCustomJSON whose godoc output examples differ from the one of ToJSON. This fixes the godoc of ToJSON output example.

morningvera
morningvera approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for contributing!

@morningvera morningvera merged commit d0c56b6 into rotisserie:master Feb 13, 2023
@sarnikowski
Copy link
Contributor Author

My pleasure :)

@sarnikowski sarnikowski deleted the docs/fix-tojson-and-tocustomjson-output-examples branch February 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningvera morningvera morningvera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarnikowski @morningvera