Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Backport 2.2] Configurable product price options by store #18

Closed
wants to merge 25 commits into from

Conversation

rostyslav-hymon
Copy link
Owner

Original Pull Request

magento#13808
Backported pull request magento#13933

Description

Some modules (e.g. Abandoned Cart, Algolia Search etc.) use store emulation functionality (\Magento\Store\Model\App\Emulation::startEnvironmentEmulation) to get product info (including configurable product price) for each store. Unfortunately LowestPriceOptionsProvider class save linked products collection at the $linkedProductMap property based on requested product id only. That is why configurable product price will be the same for other stores after first emulation.

Manual testing scenarios

As explained in magento#13933

coderimus and others added 25 commits March 20, 2018 10:00
…tion section of a loop magento#14195

 - Merge Pull Request magento#14195 from dimonovp/magento2:2.3-develop-PR-port-13173
 - Merged commits:
   1. 73099fd
   2. b4eede9
   3. a478f9d
Added test coverage to getSimpleQtyToShip and getQtyToInvoice

Fixes 14328
Trying to keep the public method count below 11
 - Merge Pull Request magento#14346 from barbazul/magento2:issue-14328
 - Merged commits:
   1. 7a0534a
   2. 5b58a34
   3. 3c65999
…#14499

 - Merge Pull Request magento#14499 from mastiuhin-olexandr/magento2:2.3-develop-PR-port-14466
 - Merged commits:
   1. 8922155
   2. c8af5d6
…ales list magento#14501

 - Merge Pull Request magento#14501 from mastiuhin-olexandr/magento2:2.3-develop-PR-port-14473
 - Merged commits:
   1. 0da00a4
…og module magento#14506

 - Merge Pull Request magento#14506 from mastiuhin-olexandr/magento2:2.3-develop-PR-port-14445
 - Merged commits:
   1. a9e4308
 - Merge Pull Request magento#14503 from mastiuhin-olexandr/magento2:2.3-develop-PR-port-14439
 - Merged commits:
   1. 54a4977
Accepted Public Pull Requests:
 - magento#14506: [Forwardport] [FIX] Simplify ternary operators for catalog module (by @mastiuhin-olexandr)
 - magento#14503: [Forwardport] Update process-reviews.js (by @mastiuhin-olexandr)
 - magento#14501: [Forwardport] Added spanish Bolivia locale to allowedLocales list (by @mastiuhin-olexandr)
 - magento#14499: [Forwardport] Correct function return statement. (by @mastiuhin-olexandr)
 - magento#14346: Fixed decimal handling in order quantities (by @barbazul)
 - magento#14195: [Forwardport] Performance: remove count() form the condition section of a loop (by @dimonovp)


Fixed GitHub Issues:
 - magento#14328: Qty to ship and Qty to invoice are handling decimals poorly (reported by @barbazul) has been fixed in magento#14346 by @barbazul in 2.3-develop branch
   Related commits:
     1. 7a0534a
     2. 5b58a34
     3. 3c65999
@rostyslav-hymon rostyslav-hymon deleted the 2.3-develop-PR-port-13808 branch April 4, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants