fix: handle 2D flux in SpectrumList #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now will unpack 2D flux in SpectrumList cases - splitter now returns SpectrumList so as to pass through the SpectrumList validation cases - moved to separate area of the code in the event anything else passes a 2D flux array (somehow) - `data_label` case has been simplified down to SpectrumList case when a 2D flux Spectrum1D is encountered
|
Thanks, there are a lot of formatting changes here that I don't want so I'm going to grab the relevant changes into a commit on my branch and add you as a coauthor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_labelcase has been simplified down to SpectrumList case when a 2D flux Spectrum1D is encountered