-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate native implementation to 'react-native-svg' #157
Conversation
@yfunk, you are right. For that purpose, I made a |
Also allow any version of the package to be used.
Add install instructions for 'react-native-svg' and update layout of Android and iOS screenshots to save some space.
I tested the example app on iOS and seems like it works well. |
@yfunk I just published Thank you for your help |
Description
Resolves #122
This pull request migrates all usage of
@react-native-community/art
in the native implementation toreact-native-svg
, since the former may be deprecated soon.This will also restore compatibility with the Expo SDK as it includes
react-native-svg
.Test plan
The native example in
./storybooks/native
doesn't work for me, which is why all changes are currently untested.The example app tries to
import QRCode from "./lib"
, which doesn't seem to exist even after building the package. I'm also pretty sure Metro doesn't allow imports from parent directories without additional configuration. Therefore, if the example app isn't part of an active Storybooks setup I'm missing, I would just create a new native example project (takingreact-native-builder-bob
as a reference) .TODO