Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to gh actions, add tests and publish wheel #44

Merged
merged 6 commits into from
Aug 3, 2024

Conversation

thatlittleboy
Copy link
Contributor

@thatlittleboy thatlittleboy commented Jan 26, 2023

Fixes #43. Tested on my own fork with test-PyPI repository.

You can see the successful GH actions here:

Wheel can be successfully installed (using py 3.10 locally)

image


Changes

  • Drop support for python 3.5 and below. The plugin code already uses f-strings, so the code won't run properly on lower versions anyway.

    base_path = os.path.dirname(config["config_file_path"])
    if isinstance(data_source_folders, str):
    data_source_folders = [f"{base_path}/{i}" for i in data_source_folders.split(',')]

  • I made the executive decision to move from Travis CI to GH actions, no particular reason other than I've no experience with Travis.

    • Tests will run on all supported python versions (3.6 till 3.11); On every commit to a pull request and on commits to the master branch.
    • Release to PyPI will be on Release creation. That's just the general practice I see, feel free to edit the trigger to suit your own workflow.
  • I bumped the version number in setup.py to 0.25.0 since it seems you already made a release on GH with that tag but pypi is still 0.24.0.

IMPT: You'll need to set up your PYPI_USER and PYPI_PASSWORD repository secrets so the CI can pick up on those variables before twine upload.

@thatlittleboy thatlittleboy marked this pull request as draft January 26, 2023 14:37
@thatlittleboy thatlittleboy marked this pull request as ready for review January 26, 2023 15:23
@rosscdh
Copy link
Owner

rosscdh commented Jan 26, 2023

Fantastic contribution! Thank you 🙇

@rosscdh rosscdh merged commit 23eea4a into rosscdh:master Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels for newer python versions
2 participants