Db stuffs #34
Merged
Db stuffs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some digging into the slack_bolt code it became evident that it's already submitting everything into a ThreadPoolExecutor so we don't need to do that ourselves. This reworks things to provide a custom executor with our names and size rather than let it create its own. It also adapts cron to handle the change. Much cleaner
|
/cc slackapi/bolt-python#509, slackapi/bolt-python#512, and slackapi/bolt-python#514 which bumps to an update of slack_bolt that uses the in-built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support mysql db in dev when env vars are defined
Rework cron validation to avoid chicken-n-egg during bootstraping
Provide executor to slack_bolt app, don't re-submit
After some digging into the slack_bolt code it became evident that it's already submitting everything into a ThreadPoolExecutor so we don't need to do that ourselves. This reworks things to provide a custom executor with our names and size rather than let it create its own. It also adapts cron to handle the change. Much cleaner