-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multiple Input files #505
Open
AddyMills
wants to merge
11
commits into
rosenbjerg:main
Choose a base branch
from
AddyMills:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
- Coverage 74.31% 70.51% -3.81%
==========================================
Files 113 116 +3
Lines 2854 2937 +83
Branches 0 284 +284
==========================================
- Hits 2121 2071 -50
- Misses 733 758 +25
- Partials 0 108 +108 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself needing to add files programatically sometimes (where I don't know the amount of inputs beforehand), especially if I were to use a custom
amix
argument. I wasn't able to figure out how to do this with the current code.In this PR, I added a new Argument file called MultiInputArgument.cs which takes in an IEnumerable with file paths, checks that all file paths exist, and then add the inputs to the FFMpeg string. If at least one path doesn't exist, it throws an error message that shows the files that don't exist/can't be accessed.
I also added a test for MultiInputArguments that passes.