Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CancellableThrough() throws if token is already cancelled #479

Closed

Conversation

gbrzeczek
Copy link

I've added the solution marked with 1. discussed in #468.

However, I think this doesn't solve the situation when cancellation is requested between calls to CancellableThrough() and ProcessAsynchronously() - I'd have to store the cancellation state somehow in the Argument Processor (maybe using a simple flag?). Please let me know what's the preferred solution.

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (f8407bc) 74.31% compared to head (4644007) 70.90%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   74.31%   70.90%   -3.42%     
==========================================
  Files         113      115       +2     
  Lines        2854     2911      +57     
  Branches        0      281     +281     
==========================================
- Hits         2121     2064      -57     
- Misses        733      739       +6     
- Partials        0      108     +108     
Files Coverage Δ
FFMpegCore/FFMpeg/FFMpegArgumentProcessor.cs 84.97% <100.00%> (-3.41%) ⬇️
FFMpegCore/FFMpeg/FFMpegArguments.cs 83.56% <100.00%> (+2.91%) ⬆️
FFMpegCore/FFMpeg/FFMpegMultiOutputOptions.cs 84.61% <84.61%> (ø)
FFMpegCore/FFProbe/FFProbeAnalysis.cs 73.84% <0.00%> (ø)
FFMpegCore/FFMpeg/Arguments/OutputTeeArgument.cs 65.62% <65.62%> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbrzeczek gbrzeczek closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants