Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added commom linters #39

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Added commom linters #39

merged 7 commits into from
Aug 28, 2024

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented Aug 21, 2024

No description provided.

@ahcorde
Enable test_robot_model_parser test
7843a26 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
improvements
8ea29a4 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
file not required anymore
661066e 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Added commom linters
66851c9 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Aug 21, 2024
@ahcorde ahcorde mentioned this pull request Aug 21, 2024
Merged
@ahcorde
deprecation parser.h header
8cd9eaa 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
clalancette
clalancette approved these changes Aug 21, 2024
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@ahcorde
Copy link
Author

ahcorde commented Aug 21, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Included ros2/rviz#1266

@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Aug 22, 2024
Merged
@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Aug 22, 2024
Merged
@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Base automatically changed from ahcorde/rolling/enable_test_robot_model_parser to rolling August 22, 2024 13:49
@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
fixed windows cppcheck
26da217 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Author

ahcorde commented Aug 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 2ff322f into rolling Aug 28, 2024
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/common_linters branch August 28, 2024 20:14
This was referenced Oct 1, 2024
Merged
Merged
@sea-bass
Copy link

sea-bass commented Oct 1, 2024 •
edited
Loading

FYI this PR seems to have broken some MoveIt tests that still import urdf/model.h because this linting PR also snuck in a compiler warning that MoveIt's CI treats as error.

See e.g. moveit/moveit2#3003 and moveit/srdfdom#127

I don't think any action is needed from here, but just informing that the MoveIt maintainer team will need to update srdfdom and moveit2 to deal with this going forward, as discussed in the 2 PRs above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @sea-bass @clalancette