Don't validate overall actions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around a limitation where the generation for the overall action doesn't know about messages in the same package. Signed-off-by: Shane Loretz<[email protected]>
This was referenced Feb 13, 2019
|
CI (test packages up to test_communication, also includes all PRs connected to this one)
|
|
CI after fixes in connected PRs
|
jacobperron
approved these changes
Feb 21, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around a limitation where the generation for the overall action doesn't know about messages in the same package. Even with this line commented out, the action fields are still validated individually when the messages and services that make up an action are generated.
Fixes ros2/rosidl#348
This PR should be backported to crystal