Revamp how we check for the correct class. #218
Conversation
In an issue it was pointed out that we are decref'ing before we actually use some of the data, which means that in theory the garbage collector could reclaim the data before we used it. So the original point of this change was to fix that issue. However, while looking at it I realized we could slightly improve performance here by avoiding a copy of the class and module into a combined string. Instead, we can compare them separately, which should reduce the copies. Signed-off-by: Chris Lalancette <[email protected]>
|
Pulls: #218
|
Since the variables are only used in an assert, which can be compiled out, this could lead to a warning. Inline the call instead, which should get rid of the warning. Signed-off-by: Chris Lalancette <[email protected]>
|
I had to add a fix when building in Release mode. Another set of CI is upcoming. |
|
Pulls: #218
|
There was a problem hiding this comment.
I don't see any issues, so LGTM!
If I were going to rewrite this module from scratch I'd make this check use PyObject_IsInstance instead of using string comparisons, but that'd require importing the class type we want to check, which we'd probably want to do once in a PyInit_*(), and I'm not sure where the PyInit_*() function even is.
In an issue it was pointed out that we are decref'ing before we actually use some of the data, which means that in theory the garbage collector could reclaim the data before we used it. So the original point of this change was to fix that issue.
However, while looking at it I realized we could slightly improve performance here by avoiding a copy of the class and module into a combined string. Instead, we can compare them separately, which should reduce the copies.
This is a partial solution to #217 ; the other reported bug in there will require a much more extensive rework.