allow byte array to use int data #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2022 15:43
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
|
and use # console A
$ ros2 topic pub -1 /whatever std_msgs/msg/ByteMultiArray "{data: [1, 2, 3]}"
# console B
$ ros2 topic echo /whatever std_msgs/msg/ByteMultiArray |
Signed-off-by: Chen Lihui <[email protected]>
fujitatomoya
requested changes
Jan 15, 2023
| @@ -0,0 +1,73 @@ | |||
| # Copyright 2022 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2022 Open Source Robotics Foundation, Inc. | |
| # Copyright 2022 Sony Group Corporation. |
| @{assert_msg_suffixes.append("and each value of type '%s'" % get_python_type(type_))}@ | ||
| @[ if get_python_type(type_) == 'bytes']@ | ||
| @{byte_array_detected = True}@ | ||
| @{assert_msg_suffixes.append("or type 'int' in range(0, 256)")}@ |
There was a problem hiding this comment.
1 byte range should be 0 to 255?
Suggested change
| @{assert_msg_suffixes.append("or type 'int' in range(0, 256)")}@ | |
| @{assert_msg_suffixes.append("or type 'int' in range(0, 255)")}@ |
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Chen Lihui <[email protected]>
fujitatomoya
approved these changes
Jan 17, 2023
|
@sloretz can you take a look? |
clalancette
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
I don't love adding more work to the assert checking; this is already a very slow portion of Python, and this will make it worse. But it does allow this to proceed, so I'm reluctantly going to approve this.
@sloretz A final review by you would be appreciated here.
|
@iuhilnehc-ynos can you rebase and start CI for this? |
added 2 commits
October 27, 2023 14:06
Signed-off-by: Chen Lihui <[email protected]>
|
CI:
|
|
@sloretz friendly ping. |
|
@sloretz any chance this can go in? I just hit this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix ros2/ros2cli#760
Signed-off-by: Chen Lihui [email protected]