-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add play-for functionality #960
Commits on Jun 1, 2022
-
Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2be261f - Browse repository at this point
Copy the full SHA 2be261fView commit details -
Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8cefe4c - Browse repository at this point
Copy the full SHA 8cefe4cView commit details -
Solves most of the comments from https://github.com/ros2/rosbag2/pull…
…/960/files (#14) * Add play-for functionality Signed-off-by: Geoffrey Biggs <[email protected]> * Add play-for to the CLI Signed-off-by: Geoffrey Biggs <[email protected]> * Adds playback_duration to PlayOptions. * Changes from PlayFor to Play srv message and changes start_offset and playback_duration. * Restores play_for tests. * Removes extra SubscriptionManager methods. * Solves comment about extra sent message. * Reorders code and comment. * Removes the SKIP_TEST flag. Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0623117 - Browse repository at this point
Copy the full SHA 0623117View commit details -
Second round of comments from ros2#960 upstream (#15)
* Removes duration parameter. A leftover after switching to playback_duration. * Fixes comment. * Solves format in rosbag2_py -> _transport.cpp * Applies style suggestions. * Changes play() to return a boolean indicating whether the request could be fulfilled. * Removes extra unnecessary code. Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4601391 - Browse repository at this point
Copy the full SHA 4601391View commit details -
Updates test execution time for ros2#960 (#16)
* Adresses reviewer's comments. * Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions() - Reduces test_play_for execution time from 50s to 6s approximately. Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58ca1a7 - Browse repository at this point
Copy the full SHA 58ca1a7View commit details -
Redesign tests in test_play_for.cpp (#17)
* Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <[email protected]> Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70b5849 - Browse repository at this point
Copy the full SHA 70b5849View commit details -
Remove unnecessary source file from test binary
Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 97dd138 - Browse repository at this point
Copy the full SHA 97dd138View commit details -
Correct errors introduced by rebase
Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a8a0a7 - Browse repository at this point
Copy the full SHA 5a8a0a7View commit details
Commits on Jun 2, 2022
-
Signed-off-by: Geoffrey Biggs <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 38ed671 - Browse repository at this point
Copy the full SHA 38ed671View commit details