Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play-for functionality #960

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Commits on Jun 1, 2022

  1. Add play-for functionality

    Signed-off-by: Geoffrey Biggs <[email protected]>
    gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2be261f View commit details
    Browse the repository at this point in the history
  2. Add play-for to the CLI

    Signed-off-by: Geoffrey Biggs <[email protected]>
    gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8cefe4c View commit details
    Browse the repository at this point in the history
  3. Solves most of the comments from https://github.com/ros2/rosbag2/pull…

    …/960/files (#14)
    
    * Add play-for functionality
    
    Signed-off-by: Geoffrey Biggs <[email protected]>
    
    * Add play-for to the CLI
    
    Signed-off-by: Geoffrey Biggs <[email protected]>
    
    * Adds playback_duration to PlayOptions.
    
    * Changes from PlayFor to Play srv message and changes start_offset and playback_duration.
    
    * Restores play_for tests.
    
    * Removes extra SubscriptionManager methods.
    
    * Solves comment about extra sent message.
    
    * Reorders code and comment.
    
    * Removes the SKIP_TEST flag.
    
    Co-authored-by: Geoffrey Biggs <[email protected]>
    Signed-off-by: Geoffrey Biggs <[email protected]>
    agalbachicar and gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0623117 View commit details
    Browse the repository at this point in the history
  4. Second round of comments from ros2#960 upstream (#15)

    * Removes duration parameter. A leftover after switching to playback_duration.
    
    * Fixes comment.
    
    * Solves format in rosbag2_py -> _transport.cpp
    
    * Applies style suggestions.
    
    * Changes play() to return a boolean indicating whether the request could be fulfilled.
    
    * Removes extra unnecessary code.
    
    Signed-off-by: Geoffrey Biggs <[email protected]>
    agalbachicar authored and gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4601391 View commit details
    Browse the repository at this point in the history
  5. Updates test execution time for ros2#960 (#16)

    * Adresses reviewer's comments.
    
    * Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions()
    
    - Reduces test_play_for execution time from 50s to 6s approximately.
    
    Signed-off-by: Geoffrey Biggs <[email protected]>
    agalbachicar authored and gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    58ca1a7 View commit details
    Browse the repository at this point in the history
  6. Redesign tests in test_play_for.cpp (#17)

    * Redesigned tests to be more deterministic and running faster
    * Fixed bug in `play_for()` flow when replaying in loop or multiple
    times from the same player instance.
    
    Signed-off-by: Michael Orlov <[email protected]>
    Signed-off-by: Geoffrey Biggs <[email protected]>
    MichaelOrlov authored and gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    70b5849 View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary source file from test binary

    Signed-off-by: Geoffrey Biggs <[email protected]>
    gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    97dd138 View commit details
    Browse the repository at this point in the history
  8. Correct errors introduced by rebase

    Signed-off-by: Geoffrey Biggs <[email protected]>
    gbiggs committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5a8a0a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Correct play_next behaviour

    Signed-off-by: Geoffrey Biggs <[email protected]>
    gbiggs committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    38ed671 View commit details
    Browse the repository at this point in the history