Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a release note about removed rclcpp subscription signatures. #4185

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add a release note about removed rclcpp subscription signatures. #4185

merged 1 commit into from
Feb 23, 2024

Conversation

clalancette
Copy link
Contributor

This goes along with ros2/rclcpp#2431

@clalancette clalancette mentioned this pull request Feb 23, 2024
Merged
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 23, 2024
christophebedard
christophebedard approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the Humble release notes to double check and found no mention of this, but the code does check out.

@clalancette clalancette merged commit cb90370 into rolling Feb 23, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/deprecated-signatures branch February 23, 2024 12:50
mergify bot pushed a commit that referenced this pull request Feb 23, 2024
@clalancette @mergify
Add a release note about removed rclcpp subscription signatures. (#4185)
a3696a4 
Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit cb90370)
@mergify mergify bot mentioned this pull request Feb 23, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 23, 2024
@clalancette @mergify
Add a release note about removed rclcpp subscription signatures. (#4185)
d47da6f 
Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit cb90370)
@mergify mergify bot mentioned this pull request Feb 23, 2024
Merged
clalancette added a commit that referenced this pull request Feb 23, 2024
@mergify @clalancette
Add a release note about removed rclcpp subscription signatures. (#4185…
05aa371 
…) (#4186)

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit cb90370)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Feb 23, 2024
@mergify @clalancette
Add a release note about removed rclcpp subscription signatures. (#4185…
77adc33 
…) (#4187)

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit cb90370)

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @christophebedard