Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: use tinyxml1 formula #4091

Merged
merged 1 commit into from
Jan 8, 2024
Merged

macOS: use tinyxml1 formula #4091

merged 1 commit into from
Jan 8, 2024

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Jan 8, 2024 •
edited
Loading

The tinyxml formula is about to be deprecated (Homebrew/homebrew-core#119829), so switch to an alternate tinyxml1 formula hosted in the osrf/simulation tap.

The tinyxml1 formula was added in osrf/homebrew-simulation#2522 and will be used by sdformat9 and gazebo11 in osrf/homebrew-simulation#2526.

@scpeters
macOS: use tinyxml1 formula
371c70f 
The tinyxml formula is about to be deprecated,
so switch to an alternate tinyxml1 formula
hosted in the osrf/simulation tap.

Signed-off-by: Steve Peters <[email protected]>
clalancette
clalancette approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let me know when you want me to merge this, and I'll also port it over to the rolling and humble branches.

@scpeters
Copy link
Contributor Author

scpeters commented Jan 8, 2024

ok, I'll let you know. Is it still needed on rolling?

@clalancette
Copy link
Contributor

ok, I'll let you know. Is it still needed on rolling?

Yeah. We keep the macOS instructions around on Rolling, even though it isn't a supported platform.

@scpeters
Copy link
Contributor Author

scpeters commented Jan 8, 2024

ok, I'll let you know. Is it still needed on rolling?

Yeah. We keep the macOS instructions around on Rolling, even though it isn't a supported platform.

I mean, is tinyxml still needed on rolling?

@clalancette
Copy link
Contributor

I mean, is tinyxml still needed on rolling?

Oh, haha. Of course not, you are right. So we only need to port this to Humble.

@scpeters
Copy link
Contributor Author

scpeters commented Jan 8, 2024

This looks good to me. Let me know when you want me to merge this, and I'll also port it over to the rolling and humble branches.

this is ready to merge since osrf/homebrew-simulation#2526 just landed

@clalancette clalancette merged commit 7956a5e into iron Jan 8, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the scpeters/macos_tinyxml1 branch January 8, 2024 22:19
@clalancette
Copy link
Contributor

@Mergifyio backport humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2024 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 8, 2024
@scpeters @mergify
macOS: use tinyxml1 formula (#4091)
7687cac 
The tinyxml formula is about to be deprecated,
so switch to an alternate tinyxml1 formula
hosted in the osrf/simulation tap.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 7956a5e)

# Conflicts:
#	source/Installation/Alternatives/macOS-Development-Setup.rst
@mergify mergify bot mentioned this pull request Jan 8, 2024
Merged
clalancette pushed a commit that referenced this pull request Jan 8, 2024
@scpeters @clalancette
macOS: use tinyxml1 formula (#4091)
10ba164 
The tinyxml formula is about to be deprecated,
so switch to an alternate tinyxml1 formula
hosted in the osrf/simulation tap.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 7956a5e)
clalancette pushed a commit that referenced this pull request Jan 8, 2024
@mergify @scpeters
macOS: use tinyxml1 formula (#4091) (#4092)
a7cdbb4 
The tinyxml formula is about to be deprecated,
so switch to an alternate tinyxml1 formula
hosted in the osrf/simulation tap.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 7956a5e)

Co-authored-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @clalancette