Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventsExecutor release notes #3662

Merged
merged 4 commits into from
May 23, 2023
Merged

Add EventsExecutor release notes #3662

merged 4 commits into from
May 23, 2023

Conversation

mjcarroll
Copy link
Member

No description provided.

@mjcarroll
Add EventsExecutor release notes
9e99f3d 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll @christophebedard
Apply suggestions from code review
2389674 
Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Christophe Bedard <[email protected]>
christophebedard
christophebedard approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

clalancette
clalancette requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, but I'd make sure that we explicitly make it clear that it is currently experimental, and thus subject to change during the lifetime of Iron.

@mjcarroll
Copy link
Member Author

Done 19fb06e

fujitatomoya
fujitatomoya approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette clalancette mentioned this pull request May 23, 2023
Merged
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label May 23, 2023
@clalancette
Fix RST markup.
b37227e 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette merged commit 07cc792 into rolling May 23, 2023
@clalancette clalancette deleted the mjcarroll-patch-1 branch May 23, 2023 12:13
mergify bot pushed a commit that referenced this pull request May 23, 2023
@mjcarroll @mergify
Add EventsExecutor release notes (#3662)
086947e 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)
mergify bot pushed a commit that referenced this pull request May 23, 2023
@mjcarroll @mergify
Add EventsExecutor release notes (#3662)
2bbd5f3 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)
mergify bot pushed a commit that referenced this pull request May 23, 2023
@mjcarroll @mergify
Add EventsExecutor release notes (#3662)
52554ea 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)
This was referenced May 23, 2023
Merged
Merged
Merged
clalancette pushed a commit that referenced this pull request May 23, 2023
@mergify @mjcarroll
Add EventsExecutor release notes (#3662) (#3666)
f1eeb76 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)

Co-authored-by: Michael Carroll <[email protected]>
clalancette pushed a commit that referenced this pull request May 23, 2023
@mergify @mjcarroll
Add EventsExecutor release notes (#3662) (#3667)
29d4819 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)

Co-authored-by: Michael Carroll <[email protected]>
clalancette pushed a commit that referenced this pull request May 23, 2023
@mergify @mjcarroll
Add EventsExecutor release notes (#3662) (#3665)
ade8981 
* Add EventsExecutor release notes

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
(cherry picked from commit 07cc792)

Co-authored-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@alsora alsora alsora approved these changes

@christophebedard christophebedard christophebedard approved these changes

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjcarroll @clalancette @christophebedard @alsora @fujitatomoya