-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tutorial for the new ParameterEventHandler class #1123
Add a tutorial for the new ParameterEventHandler class #1123
Conversation
I'm going to mark this one as a "Draft" until the dependency is merged. |
The required PR, ros2/rclcpp#829, has be merged. |
Anything stopping us from getting this merged? If I don't hear anything in the next 48 hours I am going to assume everything is ok. |
The original PR that added the functionality (ros2/rclcpp#829) was reverted. I'm not sure if its replacement has been merged yet, can you comment @mjeronimo ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me 👍
Some suggestions and questions below.
Also, more of a meta-question. Do we have some criteria for what constitutes a "beginner" tutorial versus something else?
Intuitively, I'd say this tutorial is appropriate for beginners, but I was just wondering.
That's a good question. There's no written criteria for it that I know of.
My intuition says that this should be an Intermediate tutorial. My reasoning is that a beginner doesn't have to know this information to get started using ROS 2; it's a nice additional benefit when you get into developing your own nodes. But I don't feel really strongly about it. |
@clalancette The required PR has been merged into rclcpp. I'll address Jacob's comments now. |
@clalancette @jacobperron Moved this to the Intermediate Tutorials list, per Chris' comments. |
I like that qualifier for being part of the beginner tutorials; tutorials covering stuff that users really should know about when getting started. |
Using the new class, ParameterEventsSubscriber. Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
Signed-off-by: Michael Jeronimo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor comments
Signed-off-by: Michael Jeronimo <[email protected]>
This tutorial depends on the following functionality: ros2/rclcpp#829, which should be integrated before this PR.
@Mergifyio backport rolling
Signed-off-by: Michael Jeronimo [email protected]