Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_rclcpp in ci #155

Closed
wants to merge 3 commits into from
Closed

test_rclcpp in ci #155

wants to merge 3 commits into from

Conversation

Yadunund
Copy link
Member

No description provided.

@MichaelOrlov
Copy link

@Yadunund Could you please handle this issue?
We decided to assign this issue to you at the latest waffle meeting. However, I don't have permission to change the Assignee field.

Signed-off-by: Yadunund <[email protected]>
@Yadunund
Copy link
Member Author

@CihatAltiparmak would you be willing to finish up what i started here? ie, follow-up #256 by updating the CI such that when it builds the Rolling source job, it also builds and tests test_rclcpp? The tricky part is getting the zenoh router to run in the github action along with the tests.

@CihatAltiparmak
Copy link
Contributor

CihatAltiparmak commented Aug 26, 2024

With a big pleasure. I was planning it as well. Seems like tricky part of Zenoh router is solved by 2 PRs so that tty was removed. I will start tomorrow.

@Yadunund
Copy link
Member Author

With a big pleasure. I was planning it as well. Seems like tricky part of Zenoh router is solved by 2 PRs so that tty was removed. I will start tomorrow.

Thanks so much!

@CihatAltiparmak
Copy link
Contributor

Superseded by #271 Looks like zenoh router runs without problem. Seems like easier than i guess.

@Yadunund Yadunund closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants