Added functions to get qos policies for publishers and subscribers to a topic #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build will fail until this is approved. |
jaisontj
force-pushed
the
jaisontj/get_qos_for_participants
branch
from
ad83a29
to
6282daa
Compare
|
@ivanpauno Related to this |
ivanpauno
approved these changes
Oct 16, 2019
This was referenced Oct 29, 2019
- rmw_get_publishers_info_by_topic to get the qos policies for publishers to a topic - rmw_get_subscriptions_info_by_topic to a get the qos policies for subscriptions to a topic Signed-off-by: Jaison Titus <[email protected]>
rmw_get_subscriptions_info_by_topic to RMW_RET_UNSUPPORTED. - Added a rmw_reset_error_msg() after GET_SYMBOL() to above two functions to prevent a display of "Error message being replaced. Called rcultils_reset_error() after error handling". Signed-off-by: Jaison Titus <[email protected]>
jaisontj
force-pushed
the
jaisontj/get_qos_for_participants
branch
from
6282daa
to
6dd0abf
Compare
jaisontj
commented
Nov 19, 2019
jaisontj
commented
Nov 20, 2019
Signed-off-by: Jaison Titus <[email protected]>
jaisontj
force-pushed
the
jaisontj/get_qos_for_participants
branch
from
bcb3e99
to
9879583
Compare
ivanpauno
approved these changes
Nov 22, 2019
Signed-off-by: Jaison Titus <[email protected]>
wjwwood
approved these changes
Jan 8, 2020
|
@hidmic @ivanpauno lets get this merged please :) |
I'm sorry, but I don't see any value in merging this until the comments in |
Whoops, jumped the boat early on this one, thought it was an earlier PR. My bad!! |
Signed-off-by: Miaofei <[email protected]>
ivanpauno
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of implementing this feature. The RMW layer needs to expose apis to retrieve a list of publishers and subscribers along with their QoS policies for a given topic.
a topic
a topic
Merge this PR after this is approved as the new functions depend on the newly created structure
rmw_participants_t