Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add init options API test coverage. #108

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Add init options API test coverage. #108

merged 2 commits into from
Jul 1, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 23, 2020

@hidmic hidmic requested review from brawner and Blast545 June 23, 2020 18:39
@hidmic
Copy link
Contributor Author

hidmic commented Jun 23, 2020 •
edited
Loading

CI up to rcl and test_rmw_implementation against all RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

brawner
brawner approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you monitoring coverage with these testing jobs? Is it even possible?

@hidmic
Copy link
Contributor Author

hidmic commented Jun 23, 2020 •
edited
Loading

How are you monitoring coverage with these testing jobs? Is it even possible?

I believe it is possible if I run Linux CI jobs with coverage enabled. Haven't been doing so consistently though. Too many issues with the API itself and implementations made me shift focus.

@hidmic
Copy link
Contributor Author

hidmic commented Jun 23, 2020

Also relevant. I can only test as far as the API contract goes, regardless of the implementation.

@hidmic
Minor fixes.
0eee6d5 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Contributor Author

hidmic commented Jun 24, 2020 •
edited
Loading

CI up to test_rmw_implementation against all RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Jun 24, 2020 •
edited
Loading

I'll hold off merging this until I've re-released RMWs so that rolling PR jobs pass.

@hidmic hidmic mentioned this pull request Jun 29, 2020
Merged
@hidmic
Copy link
Contributor Author

hidmic commented Jul 1, 2020

@ros-pull-request-builder retest this please

@hidmic
Copy link
Contributor Author

hidmic commented Jul 1, 2020

Going in!

@hidmic hidmic merged commit ab75a16 into master Jul 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/rmw-init-options-tests branch July 1, 2020 17:57
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@hidmic @ahcorde
Add init options API test coverage. (#108)
5dd3cbb 
Signed-off-by: Michel Hidalgo <[email protected]>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
@hidmic @ahcorde
Add init options API test coverage. (#108)
765ddf0 
Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@brawner brawner brawner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @brawner @Blast545