Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support topic instances #753

Open
wants to merge 13 commits into
base: rolling
Choose a base branch
from

Conversation

MiguelCompany
Copy link
Collaborator

@MiguelCompany MiguelCompany commented Apr 1, 2024

This PR adds the necessary code to support topic instances in rmw_fastrtps_cpp and rmw_fastrtps_dynamic_cpp

* Max samples per instance is set to history depth if KEEP_LAST
* else UNLIMITED.
*
* \param[in] hitory_qos History entitiy QoS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* \param[in] hitory_qos History entitiy QoS.
* \param[in] history_qos History entitiy QoS.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor comments. i tried review and i think this looks good, but this needs to be reviewed by someone from eProsima or other maintainers who know this area...

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@MiguelCompany
Copy link
Collaborator Author

this needs to be reviewed by someone from eProsima or other maintainers who know this area...

So the changes have been made by @Mario-DL, and I have reviewed them here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants