Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmw_count clients,services impl #641

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add rmw_count clients,services impl #641

merged 3 commits into from
Sep 29, 2023

Conversation

leeminju531
Copy link
Contributor

this PR is for service counts using it's name like topic.
Related to ros2/ros2cli#771

Signed-off-by: leeminju531 [email protected]

@gbiggs
Copy link
Member

gbiggs commented Nov 24, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@leeminju531
Copy link
Contributor Author

image

@gbiggs friendly ping, could you build again with CI_USE_FASTRTPS_DYNAMIC ?

@gbiggs
Copy link
Member

gbiggs commented Nov 27, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fujitatomoya
Copy link
Collaborator

CC: @MiguelCompany

Copy link
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methylDragon
Copy link
Contributor

methylDragon commented Feb 9, 2023

@clalancette
Copy link
Contributor

CI for this is in ros2/rmw_implementation#208 (comment)

@clalancette clalancette merged commit ad4550a into ros2:rolling Sep 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants