Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Fast-DDS Waitsets instead of listeners #619

Merged
merged 34 commits into from
Aug 24, 2022
Merged

Use Fast-DDS Waitsets instead of listeners #619

merged 34 commits into from
Aug 24, 2022

Commits on Jul 21, 2022

  1. Initial commit 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    8f9b0e8 View commit details
    Browse the repository at this point in the history

  2. Working subscriptions and services 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    6532c29 View commit details
    Browse the repository at this point in the history

  3. Add event support 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    db2ef41 View commit details
    Browse the repository at this point in the history

  4. Initial new event callback 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    905863e View commit details
    Browse the repository at this point in the history

  5. Use guard_condition with event listeners 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    3413abe View commit details
    Browse the repository at this point in the history

  6. Remove unused functions 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    7b9ca57 View commit details
    Browse the repository at this point in the history

  7. Fixing tests 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    2ee24cf View commit details
    Browse the repository at this point in the history

  8. Fixing uncrustify 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9a22e9e View commit details
    Browse the repository at this point in the history

  9. Simplify SubListener's get_unread_messages() 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ac33f66 View commit details
    Browse the repository at this point in the history

  10. Simplified get_unread_requests() and get_unread_responses() 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    a64fc56 View commit details
    Browse the repository at this point in the history

  11. Moved Waitset creation/destruction outside loop as suggested 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    6de684e View commit details
    Browse the repository at this point in the history

  12. Renamed variable. Removed unneded checks. Replaced get_unread_count w… 

    …ith get_first_untaken_info

Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    dc5d78d View commit details
    Browse the repository at this point in the history

  13. Modified oneliners. 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ec7a576 View commit details
    Browse the repository at this point in the history

  14. Cleaned more unneeded checks 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    da3ade0 View commit details
    Browse the repository at this point in the history

  15. Added RCPPUTILS_TSA_GUARDED_BY macros to previously atomic booleans 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    850eeeb View commit details
    Browse the repository at this point in the history

  16. Fixed wrong mutex guard. Renamed and removed break; from TERMINATE_TH… 

    …READ

Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    5ff6c5e View commit details
    Browse the repository at this point in the history

  17. Fix waiting events 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    6735e87 View commit details
    Browse the repository at this point in the history

  18. Fixing crash 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    fe61133 View commit details
    Browse the repository at this point in the history

  19. Fix linking error on Windows 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    67fc650 View commit details
    Browse the repository at this point in the history

  20. Usage of new function get_unread_count(bool) 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    50dd0aa View commit details
    Browse the repository at this point in the history

  21. Fix windows compilation linkage error 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    6b8946a View commit details
    Browse the repository at this point in the history

  22. Removed unneeded include. Restored some cleanup code. Added some comm… 

    …ents.

Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    cc8c3f3 View commit details
    Browse the repository at this point in the history

  23. Set nullptr after delete 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9e8865f View commit details
    Browse the repository at this point in the history

  24. Detach listener 

    Signed-off-by: Javier Santiago <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
    @jsan-rt @richiware
    jsan-rt authored and richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    cfea91c View commit details
    Browse the repository at this point in the history

  25. Fix creation of datareader for content filter 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    07838b6 View commit details
    Browse the repository at this point in the history

  26. Fix wrong usage of take_next_sample with read samples 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    b778478 View commit details
    Browse the repository at this point in the history

  27. Apply suggestions 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    62336a2 View commit details
    Browse the repository at this point in the history

  28. Apply suggestion 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    03f6b71 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Fix rosbag2 failure tests 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e95e130 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    68aacaa View commit details
    Browse the repository at this point in the history

  3. Change usage of StatusMask::operator<< 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    09cb19b View commit details
    Browse the repository at this point in the history

  4. Protecting a member 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c175f3a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8b1a886 View commit details
    Browse the repository at this point in the history

  6. Fix extra space 

    Signed-off-by: Ricardo González Moreno <[email protected]>
    @richiware
    richiware committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    fccdddd View commit details
    Browse the repository at this point in the history