Enhance TopicCache to include QoS Policies of publishers and subscribers #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaison Titus <[email protected]>
topic_cache.hpp Signed-off-by: Jaison Titus <[email protected]>
|
@ivanpauno This is the modification to Note: I moved |
jaisontj
commented
Oct 18, 2019
| @@ -180,6 +222,7 @@ class TopicCache | |||
| "rmw_fastrtps_shared_cpp", | |||
| "Unable to remove topic, does not exist '%s' with type '%s'", | |||
| topic_name.c_str(), type_name.c_str()); | |||
| return false; | |||
There was a problem hiding this comment.
@ivanpauno Added this because the current implementation seems to return true even if removal is not possible.
- Modified call to topic_cache.addTopic at custom_participant_info.hpp - Wrote tests for topic_cache Signed-off-by: Jaison Titus <[email protected]>
jaisontj
force-pushed
the
jaisontj/enhance_topic_cache_for_qos
branch
from
8cd49bd
to
3d7ee8b
Compare
|
Closing this as #336 includes these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion here. The
topic_cacheclass needs to cache the QoS policies of participants along with topic name and types; this is so that the feature request here can be implemented.Summary of changes:
Connected to aws-roadmap#83
Note:
colcon build --packages-up-to rmw_fastrtps_shared_cpp && colcon test --packages-select rmw_fastrtps_shared_cppbuilds and passes without errors or failures.Signed-off-by: Jaison Titus [email protected]