Add a common function for security files. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three of the in-tree DDS RMW implementation hard-code a list of files in the security enclave. Instead of doing this in three separate places, add in a common function that finds the set of files in the security enclave that are needed for DDS security. get_security_files() currently returns them in an unordered_map. The main reason to use a map over a structure is ABI concerns; it should be easy to add another field to the unordered_map, whereas adding one to a structure would be harder. (I intend to add something to the map in the near future). It's also not performance sensitive, so the extra string allocations shouldn't hurt performance. Signed-off-by: Chris Lalancette <[email protected]>
This was referenced Jun 24, 2021
Signed-off-by: Chris Lalancette <[email protected]>
|
Here's full CI of this PR and the ones in the individual RMWs:
|
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
|
Windows was pretty cranky, but I think I got it sorted out now. Here's another CI run:
|
|
There have been no substantial changes to this PR since the approval (just minor changes for Windows compatibility), so I'm going to go ahead and merge this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three of the in-tree DDS RMW implementation hard-code a
list of files in the security enclave. Instead of doing this
in three separate places, add in a common function that finds
the set of files in the security enclave that are needed for
DDS security.
get_security_files() currently returns them in an unordered_map.
The main reason to use a map over a structure is ABI concerns;
it should be easy to add another field to the unordered_map,
whereas adding one to a structure would be harder. (I intend
to add something to the map in the near future). It's also
not performance sensitive, so the extra string allocations
shouldn't hurt performance.
Signed-off-by: Chris Lalancette [email protected]