Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues identified while investigating #21 #22

Merged
merged 22 commits into from
Apr 13, 2021
Merged

Resolve issues identified while investigating #21 #22

merged 22 commits into from
Apr 13, 2021

Commits on Mar 31, 2021

  1. Use Rolling in README's Quick Start 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5f007c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Allow deletion of waited objects 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    229fc36 View commit details
    Browse the repository at this point in the history

  2. Only invalidate waitsets when free 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    fb22d2f View commit details
    Browse the repository at this point in the history

  3. Use C++ std WaitSets by default 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    fbb312a View commit details
    Browse the repository at this point in the history

  4. Protect status updates with mutex 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    3c76ca3 View commit details
    Browse the repository at this point in the history

  5. Remove commented out code and add wait assertion 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    efde9af View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Improved implementation of client::is_service_available for Connext Pro 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    4262e7a View commit details
    Browse the repository at this point in the history

  2. Only add request header to typecode with Basic req/rep profile 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    80524f7 View commit details
    Browse the repository at this point in the history

  3. Uncrustify errors 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    afe28ee View commit details
    Browse the repository at this point in the history

  4. Enable new is_service_available for Micro too 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    c812e7c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Resolve linter errors 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    0b8fd8a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Remove unnecessary boolean flags 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    e090686 View commit details
    Browse the repository at this point in the history

  2. Avoid race conditions between WaitSets and Conditions 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    876ba51 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Cache data available in the RMW 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    8922b29 View commit details
    Browse the repository at this point in the history

  2. Protect data available with waitset lock 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ce1401e View commit details
    Browse the repository at this point in the history

  3. Clean up waitset synchronization 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    b35d211 View commit details
    Browse the repository at this point in the history

  4. Disable DDS-based WaitSet implementation 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    a5f5e74 View commit details
    Browse the repository at this point in the history

  5. Remove commented/unused code 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2715a2f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Resolve compiler warnings for unused variables 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    71df269 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. * Avoid topic name validation in get_info functions 

    * Reduce shutdown period to 10ms
* Pass HistoryQosPolicy to graph cache
* Reset error string after looking up type support

Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    dc75a84 View commit details
    Browse the repository at this point in the history

  2. Restore checks for valid topic name 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    7de7492 View commit details
    Browse the repository at this point in the history

  3. Remove DDS-based WaitSet implementation 

    Signed-off-by: Andrea Sorbini <[email protected]>
    @asorbini
    asorbini committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    ce3f86d View commit details
    Browse the repository at this point in the history