-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event listeners updated #116
Merged
clalancette
merged 11 commits into
ros2:asorbini/event-listeners
from
cwecht:event-listeners-updated
May 9, 2023
Merged
Event listeners updated #116
clalancette
merged 11 commits into
ros2:asorbini/event-listeners
from
cwecht:event-listeners-updated
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <[email protected]>
* Use the new discovery params Signed-off-by: Michael X. Grey <[email protected]> * Update to latest rmw API Signed-off-by: Michael X. Grey <[email protected]> * Fix typo Signed-off-by: Michael X. Grey <[email protected]> * Fix memory management Signed-off-by: Michael X. Grey <[email protected]> * Make sure NDDS_DISCOVERY_PEERS is not empty when ROS_AUTOMATIC_DISCOVERY_RANGE is LOCALHOST Signed-off-by: Andrea Sorbini <[email protected]> * fix up finalize logic Signed-off-by: William Woodall <[email protected]> * typo Signed-off-by: William Woodall <[email protected]> * check the return code of ensure_length() Signed-off-by: William Woodall <[email protected]> * fixup use of memcpy when copying a string Signed-off-by: William Woodall <[email protected]> * improve formatting of domain_tag string Signed-off-by: William Woodall <[email protected]> * use c++17 [[fallthrough]] attribute Signed-off-by: William Woodall <[email protected]> * change style of switch statement Signed-off-by: William Woodall <[email protected]> * undo change to request c++17 vs 14 since we're not using fallthrough Signed-off-by: William Woodall <[email protected]> * Handle all discovery options in rmw_context.cpp Signed-off-by: Andrea Sorbini <[email protected]> * Reset multicast_receive_addresses instead of setting NDDS_DISCOVERY_PEERS Signed-off-by: Andrea Sorbini <[email protected]> * error when range is NOT_SET Signed-off-by: William Woodall <[email protected]> * fixup review comments Signed-off-by: William Woodall <[email protected]> * fix a zero initialization issue Signed-off-by: William Woodall <[email protected]> * remove redundant break statement Signed-off-by: William Woodall <[email protected]> * Init discovery_options when initializing node options Signed-off-by: Shane Loretz <[email protected]> * Set maximum participant ID to 32 on localhost Signed-off-by: Shane Loretz <[email protected]> * Skipping adding peers when automatic_discovery_range is SYSTEM_DEFAULT Signed-off-by: Shane Loretz <[email protected]> * Try solving los of precision warning on Windows Signed-off-by: Shane Loretz <[email protected]> * Fix windows warning Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: William Woodall <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Andrea Sorbini <[email protected]> Co-authored-by: William Woodall <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
This reverts commit 882c7f1.
* Refactor serialization support to use allocators and refs Signed-off-by: methylDragon <[email protected]> * Use rmw_serialization_support_init Signed-off-by: methylDragon <[email protected]> --------- Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Christopher Wecht <[email protected]>
Signed-off-by: Christopher Wecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.