Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmw_get_node_names needs to include namespaces #142

Closed
dirk-thomas opened this issue Jun 27, 2018 · 1 comment
Closed

rmw_get_node_names needs to include namespaces #142

dirk-thomas opened this issue Jun 27, 2018 · 1 comment
Assignees
@mjcarroll
Labels
bug Something isn't working

Comments

@dirk-thomas
Copy link
Member

Nodes are creating with a name as well as a namespace. The function rmw_create_node only returns the name though. It should include the namespace as well - either as separate return values or as a combined value.

Follow up of #95.
@dirk-thomas dirk-thomas added the bug Something isn't working label Jun 27, 2018
@dhood
Copy link
Member

dhood commented Jun 27, 2018

For cross-referencing: this will allow ros2/ros2cli#105 to be resolved

@dirk-thomas dirk-thomas mentioned this issue Jun 27, 2018
Closed
@mjcarroll mjcarroll self-assigned this Aug 28, 2018
@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Aug 28, 2018
This was referenced Aug 28, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mjcarroll mjcarroll added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 29, 2018
This was referenced Sep 1, 2018
Closed
Closed
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Sep 6, 2018
@dirk-thomas dirk-thomas mentioned this issue Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjcarroll mjcarroll

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjcarroll @dirk-thomas @dhood