Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qsort to the excluded patterns. #346

Closed
wants to merge 1 commit into from

Conversation

clalancette
Copy link
Contributor

This gets rid of the last rosdoc2 warning on the buildfarm.

Signed-off-by: Chris Lalancette [email protected]

The last warning can be seen at the end of the log here: https://build.ros2.org/view/Rdoc/job/Rdoc__rcutils__ubuntu_focal_amd64/4/console .

It's not ideal to be disabling the generation of the docs for this, but I think it is more important to get some green Rdoc builds going than fixing this one lightly-used API. We can always try to make it work later.

This gets rid of the last rosdoc2 warning on the buildfarm.

Signed-off-by: Chris Lalancette <[email protected]>
@wjwwood
Copy link
Member

wjwwood commented Aug 10, 2021

I think this is the issue @aprotyas originally found related to a issue with newer versions of breathe.

This might remove the last warning from here but it's a system problem that we'll probably run into over and over unless we get a fix in breathe or pin the version back.

@aprotyas
Copy link
Member

Yes, this is a known issue breathe-doc/breathe#722 and it looks like there is a fix in the process.

Till then, either the problematic signatures can be excluded - but this would fix the problem only for this repo - or a specific version of breathe (<=4.26.0) can be pinned back in the Rdoc jobs.

@clalancette
Copy link
Contributor Author

With the latest release of breathe (4.31.0), this is no longer a problem. So closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants