Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows messages when atomic type is unsupported #145

Merged
merged 7 commits into from
Apr 10, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Apr 8, 2019

This PR uses a default value if ROS_PACKAGE_NAME is not set, which appears to be the case for rclpy. Also it adds a compile time message when an atomic type is not supported in addition to the existing runtime error. (Edit, second part makes no sense. See comment below)

From https://ci.ros2.org/job/ci_windows/6471/consoleText

(ClCompile target) -> 
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(90): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(98): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(106): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(114): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(128): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(139): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(147): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(155): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(163): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]
  C:\J\workspace\ci_windows\ws\install\include\rcutils/stdatomic_helper.h(171): error C2065: 'ROS_PACKAGE_NAME': undeclared identifier [C:\J\workspace\ci_windows\ws\build\rclpy\rclpy_signal_handler.vcxproj]

@sloretz sloretz added the in review Waiting for review (Kanban column) label Apr 8, 2019
@sloretz sloretz self-assigned this Apr 8, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Apr 8, 2019

CI (packages above rcutils, windows only since this header is only included on that platform)
Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Apr 8, 2019

Not sure what I was thinking with the #pragma message, it makes no sense because the preprocessor can't know the size of the types and the logic is done at runtime using a switch statement. Removed the build time messages in 66a1041

@sloretz
Copy link
Contributor Author

sloretz commented Apr 8, 2019

CI (windows only, testing packages above rcutils)
Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Apr 8, 2019

One more time with CI Build Status

ab9ea67 removed the undef of _RCUTILS_PACKAGE_NAME. IIUC it can't be undef'd because the macros using it still refer to it.

@sloretz
Copy link
Contributor Author

sloretz commented Apr 10, 2019

Only test_params_yaml ros2/build_farmer#166 failed. I'm assuming ab9ea67 did not change anyone's mind about approving and merging.

@sloretz sloretz merged commit 1cb9d67 into master Apr 10, 2019
@sloretz sloretz deleted the sloretz/warn_unsupported_atomic branch April 10, 2019 18:16
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants