-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread_safety_annotation filename to .hpp #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test must be updated too.
@emersonknapp Can you attach a Gist to this PR so that I can run CI? |
@thomas-moulard the test is updated - maybe you were looking at an outdated version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm - indeed it is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the CI is green.
@emersonknapp this is green - please add a DCO to this one and merge 🚢 |
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp [email protected]