Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress clang error because of deprecation #199

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 25, 2024

No description provided.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from clalancette July 25, 2024 11:41
@ahcorde ahcorde self-assigned this Jul 25, 2024
@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 25, 2024

Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but otherwise looks good to me.

# ifdef __clang__
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdeprecated-declarations"
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#endif
# endif

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI on the regular CI, plus the Clang job.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 25, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
  • Clang Build Status

@fujitatomoya fujitatomoya merged commit f9f667d into rolling Jul 25, 2024
3 checks passed
@fujitatomoya fujitatomoya deleted the ahcorde/rolling/clean_warning_error_clang branch July 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants