[env] Add set_env_var function
#150
Conversation
This commit adds the `set_env_var` function, which is essentially an
`rcpputils` wrapper around `rcutils_set_env`.
In doing so, also:
- Rename `get_env.{hpp,cpp}` to `env.{hpp,cpp}`
- Update FEATURES.md with new signature
Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Also, renamed `test_get_env.cpp` to `test_env.cpp` to reflect the addition of a new function. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
Signed-off-by: Abrar Rahman Protyasha <[email protected]>
|
Running CI.
|
|
About the macOS test failures: these have been reported as flaky in ros2/rcl#750, and they don't look related. Oddly, these tests also failed in a CI run for ros2/rcl#946. About the windows test failures: not sure what's going on. All failing tests seem to be of the "graceful termination" type. |
It's better to deprecate the header on a tick-tock cycle rather than removing it outright, so this commit reverts the deletion and actually deprecates the header. Signed-off-by: Abrar Rahman Protyasha <[email protected]>
|
I just realized that the Having said that, I've reverted the deletion of |
|
Ah, i missed that, sorry. there should be a lifecycle for deprecation. |
|
Running CI again following 18b406b. Repos file: https://gist.github.com/aprotyas/96874af9175859555af0144398e0bf25
|
|
Two approvals and CI is green, so I'll merge this in. Thanks for the reviews! |
This PR adds the
set_env_varfunction, which is essentially anrcpputilswrapper aroundrcutils_set_env.I've also renamed
get_env.{hpp,cpp}toenv.{hpp,cpp}given the addition of a new method to the "environment helper" functions.Downstream PRs necessitated by this change:
rcpputilsheader rcl_logging#81rcpputilsheader rmw_implementation#198rcpputilsheader ros-perception/image_common#211Closes #149.
Signed-off-by: Abrar Rahman Protyasha [email protected]